Merge SSH keygen changes (Step 2) and troubleshooting to Main Branch#538
Conversation
2 new screenshots to demonstrate the new key for ssh documentation
Updating RMACC registry instructions to reflect the same instructions as the SSH authentication setup for AMC
b-reyes
left a comment
b-reyes
left a comment
There was a problem hiding this comment.
@MSherren Thank you so much for putting this together! I have some changes that I would like you to make so that the content follows some of the guidelines we have established in our documentation. Also, I suggested a small modification to your troubleshooting addition. If you have any questions on these changes, please let me know.
Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
|
I believe I have added all the right commits for both the registry cilogon instructions and the AMC ssh auth instructions. Please let me know if there are any other edits or feedback! |
Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
b-reyes
left a comment
b-reyes
left a comment
There was a problem hiding this comment.
Hi @MSherren thank you for making those changes. In this round of review I identified a couple of issues. Please address these and apply all changes that were made in the AMC page to the general Uploading an SSH Key to CILogon Registry as well, if they are applicable.
See line 102, attempt to add "Note" in official syntax form
Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
Clarifying example output in a more readable format Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
Changed all references of id_rsa to id_ed25519
Optional instructions added to rename the key should the user choose, so it doesn't result in the default
Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
Separating password and passphrase troubleshooting to be more clear Co-authored-by: Brandon <53541061+b-reyes@users.noreply.github.com>
Updated registry CI logon instructions (Steps 1-3 and troubleshooting) to match the updates to the AMC ssh instructions
|
I believe all necessary changes have been made to both the amc_ssh_auth.md doc and the registrycilogon-instructions.md doc. I will note, the original registrycilogon-instructions.md document differs from the AMC ssh document as it doesn't have a Step 4 and the troubleshooting is shorter. I have kept these differences, so there is no Step 4 and the troubleshooting instructions are less for the registrycilogon-instructions.md document, though I did still update the troubleshooting sections that matched. |
Tab set for Windows vs Mac
…n, add additionaly toublehsooting tips to the registrycilogon-instructions page
2 participants
After discovering the instructions for ssh keygen (step 2) were slightly out of date, generating an rsa key, I have updated the documentation to generate a newer ssh key. Additionally, I have added a troubleshooting step for the issue certain Mac's have run into.